Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: events/eventtarget throws #33782

Closed
mscdex opened this issue Jun 7, 2020 · 2 comments
Closed

benchmark: events/eventtarget throws #33782

mscdex opened this issue Jun 7, 2020 · 2 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter. eventtarget Issues and PRs related to the EventTarget implementation.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jun 7, 2020

  • Version: master
  • Platform: Linux
  • Subsystem: events

The events/eventtarget.js benchmark fails every time with:

internal/event_target.js:250
      throw new ERR_EVENT_RECURSION(event.type);
      ^

Error [ERR_EVENT_RECURSION]: The event "foo" is already being dispatched
    at EventTarget.dispatchEvent (internal/event_target.js:250:13)
    at main (/home/bench/node/benchmark/events/eventtarget.js:20:12)
    at /home/bench/node/benchmark/common.js:42:9
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  code: 'ERR_EVENT_RECURSION'
}

/cc @jasnell

@mscdex mscdex added events Issues and PRs related to the events subsystem / EventEmitter. benchmark Issues and PRs related to the benchmark subsystem. labels Jun 7, 2020
@benjamingr
Copy link
Member

I think this is already fixed by #33624 which just needs to land (along with the other PRs)

@jasnell jasnell added the eventtarget Issues and PRs related to the EventTarget implementation. label Jun 19, 2020
@mscdex
Copy link
Contributor Author

mscdex commented Jun 19, 2020

Can we temporarily remove this benchmark in the meantime? I checked and the linked PR is evidently not enough to fix the error with the benchmark. In particular this issue is currently preventing the gathering of all events benchmark data (EventTarget or otherwise) in my daily benchmark runner.

mscdex added a commit to mscdex/io.js that referenced this issue Jun 21, 2020
jasnell pushed a commit to jasnell/node that referenced this issue Jun 22, 2020
codebytere pushed a commit that referenced this issue Jun 27, 2020
Fixes: #33782

PR-URL: #34015
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
codebytere pushed a commit that referenced this issue Jun 30, 2020
Fixes: #33782

PR-URL: #34015
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter. eventtarget Issues and PRs related to the EventTarget implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants