Skip test-worker-no-sab #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syg
approved these changes
Apr 14, 2023
pthier
pushed a commit
that referenced
this pull request
Apr 26, 2023
victorgomes
pushed a commit
that referenced
this pull request
May 22, 2023
pthier
pushed a commit
that referenced
this pull request
Jul 4, 2023
pthier
pushed a commit
that referenced
this pull request
Aug 24, 2023
victorgomes
pushed a commit
that referenced
this pull request
Sep 12, 2023
victorgomes
pushed a commit
that referenced
this pull request
Sep 12, 2023
victorgomes
pushed a commit
that referenced
this pull request
Nov 8, 2023
pthier
pushed a commit
that referenced
this pull request
Jan 17, 2024
victorgomes
pushed a commit
that referenced
this pull request
Feb 14, 2024
victorgomes
pushed a commit
that referenced
this pull request
Mar 4, 2024
pthier
pushed a commit
that referenced
this pull request
Mar 21, 2024
victorgomes
pushed a commit
that referenced
this pull request
Apr 23, 2024
victorgomes
added a commit
that referenced
this pull request
Jun 3, 2024
# Conflicts: # test/parallel/parallel.status
pthier
pushed a commit
that referenced
this pull request
Jul 15, 2024
# Conflicts: # test/parallel/parallel.status
victorgomes
added a commit
that referenced
this pull request
Aug 22, 2024
# Conflicts: # test/parallel/parallel.status
pthier
pushed a commit
that referenced
this pull request
Oct 2, 2024
# Conflicts: # test/parallel/parallel.status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test depends on the --harmony-sharedarraybuffer flag, which is always true and will be removed.
Since the test is a regression test for nodejs#39717, about the repl crashing
when SABs are disabled, skipping the test unconditionally seems appropriate here.