Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL fips.ld and legacy.ld missing for Windows #40854

Closed
targos opened this issue Nov 18, 2021 · 5 comments
Closed

OpenSSL fips.ld and legacy.ld missing for Windows #40854

targos opened this issue Nov 18, 2021 · 5 comments
Assignees
@danbev
Labels
build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. windows Issues and PRs related to the Windows platform.

Comments

@targos
Copy link
Member

targos commented Nov 18, 2021

Referenced in

node/deps/openssl/config/archs/VC-WIN64A/asm/openssl.gypi

Lines 1001 to 1002 in 0a3a601

'./config/archs/VC-WIN64A/asm/providers/legacy.ld',
'./config/archs/VC-WIN64A/asm/providers/fips.ld',
,

node/deps/openssl/config/archs/VC-WIN32/asm/openssl.gypi

Lines 983 to 984 in 0a3a601

'./config/archs/VC-WIN32/asm/providers/legacy.ld',
'./config/archs/VC-WIN32/asm/providers/fips.ld',
and similar (asm_avx2, no-asm, VC-WIN64-ARM, etc)

These files don't exist.
@targos targos added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. openssl Issues and PRs related to the OpenSSL dependency. labels Nov 18, 2021
@targos
Copy link
Member Author

targos commented Nov 21, 2021

@danbev

@danbev
Copy link
Contributor

danbev commented Nov 21, 2021

@targos I'm currently on a leave of absence and I won't be able to look into this issue. Hopefully someone else in the community can take a look.

@mhdawson
Copy link
Member

mhdawson commented Dec 3, 2021

These are the instructions for generating the files in case somebody wants to take a run through generating and adding the missing files. - https://github.com/nodejs/node/blob/master/doc/guides/maintaining-openssl.md

@dkemper01
Copy link

Hello,

I ran into this issue

←[1m←[93mWARNING←[0m: warnings were emitted in the configure phase
Warning: Missing input files:
deps\openssl\config\archs\VC-WIN64A\no-asm\providers\fips.ld
deps\openssl\config\archs\VC-WIN64A\no-asm\providers\legacy.ld

During a windows FIPS-compliant build using

.\vcbuild openssl-no-asm

However, the link posted above by @mhdawson is a dead link unfortunately. Any guidance on this issue would be appreciated.

@mhdawson
Copy link
Member

@dkemper01 this is the updated link for the above - https://github.com/nodejs/node/blob/master/doc/contributing/maintaining-openssl.md

@danbev danbev self-assigned this May 5, 2022
danbev added a commit to danbev/node that referenced this issue May 5, 2022
@danbev
deps: exclude linker scripts for windows builds
581739a 
This commit ignore fips.ld and legacy.ld linker scripts for Windows
environments.

Fixes: nodejs#40854
@danbev danbev mentioned this issue May 5, 2022
Closed
danbev added a commit to danbev/node that referenced this issue May 16, 2022
@danbev
deps: exclude linker scripts for windows builds
1ecf3c4 
This commit ignore fips.ld and legacy.ld linker scripts for Windows
environments.

Fixes: nodejs#40854
@danbev danbev closed this as completed in c3a127d May 30, 2022
bengl pushed a commit that referenced this issue May 30, 2022
@danbev @bengl
deps: exclude linker scripts for windows builds
ecacc3a 
This commit ignore fips.ld and legacy.ld linker scripts for Windows
environments.

PR-URL: #42973
Fixes: #40854
Reviewed-By: Michael Dawson <midawson@redhat.com>
F3n67u pushed a commit to F3n67u/node that referenced this issue Jun 1, 2022
@danbev @F3n67u
deps: exclude linker scripts for windows builds
24cfada 
This commit ignore fips.ld and legacy.ld linker scripts for Windows
environments.

PR-URL: nodejs#42973
Fixes: nodejs#40854
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbev danbev

Labels
build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: exclude linker scripts for windows builds danbev/node
4 participants
@danbev @targos @dkemper01 @mhdawson