Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build setup creates untracked files in deps/openssl #40855

Closed
targos opened this issue Nov 18, 2021 · 2 comments · Fixed by #40967
Closed

Windows build setup creates untracked files in deps/openssl #40855

targos opened this issue Nov 18, 2021 · 2 comments · Fixed by #40967
Labels
build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. windows Issues and PRs related to the Windows platform.

Comments

@targos
Copy link
Member

targos commented Nov 18, 2021

After .\vcbuild.bat projgen nobuild:

> git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        deps/openssl/openssl-fipsmodule.props
        deps/openssl/openssl-fipsmodule.targets
        deps/openssl/openssl-fipsmodule.xml
@targos targos added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. labels Nov 18, 2021
@targos
Copy link
Member Author

targos commented Nov 21, 2021

@danbev

@danbev
Copy link
Contributor

danbev commented Nov 21, 2021

@targos I'm currently on a leave of absence and I won't be able to look into this issue. Hopefully someone else in the community can take a look.

lpinca added a commit to lpinca/node that referenced this issue Nov 25, 2021
@lpinca
build: add OpenSSL gyp artifacts to .gitignore
b505312 
Fixes: nodejs#40855
@lpinca lpinca mentioned this issue Nov 25, 2021
Merged
nodejs-github-bot pushed a commit that referenced this issue Nov 27, 2021
@lpinca
build: add OpenSSL gyp artifacts to .gitignore
eadfbae 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this issue Dec 13, 2021
@lpinca @danielleadams
build: add OpenSSL gyp artifacts to .gitignore
1b6d107 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this issue Dec 14, 2021
@lpinca @danielleadams
build: add OpenSSL gyp artifacts to .gitignore
29739f8 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 30, 2022
@lpinca @danielleadams
build: add OpenSSL gyp artifacts to .gitignore
2796e75 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
@lpinca @danielleadams
build: add OpenSSL gyp artifacts to .gitignore
b72e50e 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: add OpenSSL gyp artifacts to .gitignore lpinca/node
2 participants
@danbev @targos