-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build break: Failed to generate license.rtf
#43213
Comments
Actually scratch that, the last CI for that PR was broken: https://ci.nodejs.org/job/node-test-pull-request/44161/. I'll open a revert. |
Revert PR: #43214 |
@richardlau do you have any idea why the windows build failed? I am not familiar with Nodejs Jenkins pipeline and windows stuff. |
No I do not. There wasn't any further error messages to indicate why. |
@richardlau I found the reason why #43101 will cause windows build break. I made a pr: #43232, please take a look. |
This reverts commit 331088f. PR-URL: nodejs/node#43232 Refs: nodejs/node#43213 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Version
nightly
Platform
Windows
Subsystem
No response
What steps will reproduce the bug?
Windows CI builds are failing.
How often does it reproduce? Is there a required condition?
Today's daily master build and a number of CI's for pull requests.
What is the expected behavior?
Build completes.
What do you see instead?
Build fails. e.g. https://ci.nodejs.org/job/node-compile-windows/45207/nodes=win-vs2019/console
Additional information
#43101 landed yesterday and looks very relevant.
That passed its CI but maybe something else has landed that when combined causes the break?cc @nodejs/platform-win
The text was updated successfully, but these errors were encountered: