Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node:util] Incorrect order in util.parseArgs history #45670

Closed
Semigradsky opened this issue Nov 29, 2022 · 3 comments · Fixed by #45728
Closed

[node:util] Incorrect order in util.parseArgs history #45670

Semigradsky opened this issue Nov 29, 2022 · 3 comments · Fixed by #45728
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. util Issues and PRs related to the built-in util module.

Comments

@Semigradsky
Copy link
Contributor

Affected URL(s)

https://nodejs.org/docs/latest-v18.x/api/util.html#utilparseargsconfig

Description of the problem

There is incorrect order in util.parseArgs history:
image
@Semigradsky Semigradsky added the doc Issues and PRs related to the documentations. label Nov 29, 2022
@VoltrexKeyva VoltrexKeyva added the util Issues and PRs related to the built-in util module. label Nov 29, 2022
@Trott Trott added the good first issue Issues that are suitable for first-time contributors. label Nov 30, 2022
@bleakprestiger
Copy link

Can I Take This Issue, I want to work on this issue.

bleakprestiger added a commit to bleakprestiger/node that referenced this issue Dec 3, 2022
@bleakprestiger
doc: fix Incorrect order in util.parseArgs history
5fb6be3 
fix incorrect order in util.parseArgs history in the util.md

Fixed ordering in the versioning history for the util.parseArgs function in the util.md.

Fixes: -nodejs#45670
This was referenced Dec 3, 2022
Closed
Merged
@bleakprestiger
Copy link

@Semigradsky @Trott @VoltrexKeyva I have created a Pull Request For fixing of incorrect ordering of util.parseArgs.
Pull Request ID - #45726

welfoz added a commit to welfoz/node that referenced this issue Dec 3, 2022
@welfoz
tools: fix incorrect version history order
7b9432f 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string (ie. a = ["v18.11, v16.7.0"])
with an array of strings (ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string like
a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Fixes: nodejs#45670
@welfoz welfoz mentioned this issue Dec 3, 2022
Merged
@welfoz
Copy link
Contributor

welfoz commented Dec 3, 2022

Hey @bleakprestiger!
I'm sorry I was working on this since yesterday. I think I've figured it out.
The problem was not directly in the YAML comment but in the tool who parse it :)

welfoz added a commit to welfoz/node that referenced this issue Dec 4, 2022
@welfoz
tools: fix added version is always the first one
5e4afb9 
There is no need to sort the addded version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 4, 2022
@welfoz
test: fix parsing yaml history versions order
80f67b1 
The added version in now always the lastest
in the HTML table.

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 4, 2022
@welfoz
tools: fix incorrect version history order
4dc3067 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"])with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify
string like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 4, 2022
@welfoz
tools: fix added version is always the first one
fc7bcfe 
There is no need to sort the addded version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 4, 2022
@welfoz
test: fix parsing yaml history versions order
34833b9 
The added version in now always the lastest
in the HTML table.

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 4, 2022
@welfoz
tools: fix incorrect version history order
a21d4f7 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 4, 2022
@welfoz
tools: fix added version is always the first one
7afce83 
There is no need to sort the addded version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 4, 2022
@welfoz
test: fix parsing yaml history versions order
cc0f45a 
The added version in now always the lastest
in the HTML table.

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 12, 2022
@welfoz
tools: fix incorrect version history order
80ff6f6 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Therefore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 12, 2022
@welfoz
tools: fix incorrect version history order
29ae0d1 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Futhermore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

Fixes: nodejs#45670
welfoz added a commit to welfoz/node that referenced this issue Dec 12, 2022
@welfoz @lpinca
tools: fix incorrect version history order
971dcc3 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Futhermore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: nodejs#45670

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
welfoz added a commit to welfoz/node that referenced this issue Dec 12, 2022
@welfoz @lpinca
tools: fix incorrect version history order
7f7ecaf 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Furthermore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: nodejs#45670

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this issue Dec 14, 2022
@welfoz @lpinca
tools: fix incorrect version history order
bfb5ba7 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Furthermore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: #45670

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Jan 1, 2023
@welfoz @lpinca @targos
tools: fix incorrect version history order
124c2b3 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Furthermore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: #45670

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this issue Jan 26, 2023
@welfoz @lpinca @juanarbol
tools: fix incorrect version history order
e0cda56 
This fixes an error in parseYAML(text), the version sorting
coudn't be right as we compared an arrify string
(ie. a = ["v18.11, v16.7.0"]) with an array of strings
(ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).

minVersion(a) couldn't find the minimum version with an arrify string
like a = ["v18.11, v16.7.0"].
That's why incorrect version history orders sometimes appeared.

Furthermore, no need to sort the added version as it always comes first.
So, it can be the last one to be pushed in the meta.changes array.

Fixes: #45670

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #45728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: fix incorrect version history order welfoz/node
5 participants
@Trott @Semigradsky @VoltrexKeyva @bleakprestiger @welfoz