Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: polish test-net-better-error-messages-listen #10087

Closed
wants to merge 1 commit into from
Closed

test: polish test-net-better-error-messages-listen #10087

wants to merge 1 commit into from

Conversation

digitalinfinity
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Cleans up test-net-better-error-messages-list.js with following:

  • var -> cons
  • assert.equal -> assert.strictEqual

@digitalinfinity
test: polish test-net-better-error-messages-listen
1f989af 
Cleans up test-net-better-error-messages-list.js with following:
- var -> cons
- assert.equal -> assert.strictEqual
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 2, 2016
evanlucas
evanlucas suggested changes Dec 2, 2016
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but there is a typo in the commit message:

- var -> cons should be - var -> const

addaleax
addaleax approved these changes Dec 2, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @evanlucas’ nit (can also be done when landing)

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Dec 3, 2016
@addaleax
Copy link
Member

addaleax commented Dec 4, 2016

Landed in 6d54c87, thanks for the contribution!

@addaleax addaleax closed this Dec 4, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016
@digitalinfinity @addaleax
test: polish test-net-better-error-messages-listen
6d54c87 
Cleans up test-net-better-error-messages-list.js with following:
- var -> const
- assert.equal -> assert.strictEqual

PR-URL: nodejs#10087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@digitalinfinity @addaleax
test: polish test-net-better-error-messages-listen
c4902e4 
Cleans up test-net-better-error-messages-list.js with following:
- var -> const
- assert.equal -> assert.strictEqual

PR-URL: #10087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@digitalinfinity @addaleax
test: polish test-net-better-error-messages-listen
7bf13f3 
Cleans up test-net-better-error-messages-list.js with following:
- var -> const
- assert.equal -> assert.strictEqual

PR-URL: nodejs#10087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@digitalinfinity
test: polish test-net-better-error-messages-listen
839649c 
Cleans up test-net-better-error-messages-list.js with following:
- var -> const
- assert.equal -> assert.strictEqual

PR-URL: nodejs#10087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@digitalinfinity @MylesBorins
test: polish test-net-better-error-messages-listen
37d734a 
Cleans up test-net-better-error-messages-list.js with following:
- var -> const
- assert.equal -> assert.strictEqual

PR-URL: #10087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@digitalinfinity @MylesBorins
test: polish test-net-better-error-messages-listen
ff045d8 
Cleans up test-net-better-error-messages-list.js with following:
- var -> const
- assert.equal -> assert.strictEqual

PR-URL: #10087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@digitalinfinity @MylesBorins
test: polish test-net-better-error-messages-listen
7264daa 
Cleans up test-net-better-error-messages-list.js with following:
- var -> const
- assert.equal -> assert.strictEqual

PR-URL: #10087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlucas evanlucas evanlucas requested changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@digitalinfinity @addaleax @evanlucas @targos @cjihrig @mscdex @MylesBorins @nodejs-github-bot