Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reduce unmanaged parallelism in test #10329

Closed
wants to merge 1 commit into from
Closed

test: reduce unmanaged parallelism in test #10329

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Dec 19, 2016 •
edited
Loading

The original test lauches 10 child processes at once
and bypass test.py's process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for #9979 (not a real fix).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Ref:

@joyeecheung
test: reduce unmanaged parallelism in test
78e5a06 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for nodejs#9979 (not a real fix).
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Dec 19, 2016
addaleax
addaleax approved these changes Dec 19, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-commit/6718/

@mscdex mscdex added the domain Issues and PRs related to the domain subsystem. label Dec 19, 2016
@joyeecheung
Copy link
Member Author

Ping. The ARM build failure on the CI looks unrelated?

@Trott
Copy link
Member

Trott commented Dec 22, 2016

Ping. The ARM build failure on the CI looks unrelated?

Not just unrelated, but non-existent! Ci is green. The widget has been incorrectly reporting ARM failures for a few days now. (I'm not sure if the issue is something on the build infra side or the github bot side. So I'm not even sure who to ping about it!)

TL;DR: CI is ✅

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 22, 2016
@joyeecheung @Trott
test: reduce unmanaged parallelism in domain test
a165232 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for nodejs#9979 (not a real fix).

PR-URL: nodejs#10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member

Trott commented Dec 22, 2016

Landed in a165232.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 22, 2016
@joyeecheung joyeecheung deleted the split-test-aoue branch January 2, 2017 05:28
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@joyeecheung @italoacasas
test: reduce unmanaged parallelism in domain test
62bd180 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for nodejs#9979 (not a real fix).

PR-URL: nodejs#10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@joyeecheung @italoacasas
test: reduce unmanaged parallelism in domain test
20443d9 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for nodejs#9979 (not a real fix).

PR-URL: nodejs#10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@joyeecheung @italoacasas
test: reduce unmanaged parallelism in domain test
4377716 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for nodejs#9979 (not a real fix).

PR-URL: nodejs#10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@joyeecheung @italoacasas
test: reduce unmanaged parallelism in domain test
e2b631f 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for nodejs#9979 (not a real fix).

PR-URL: nodejs#10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@joyeecheung @italoacasas
test: reduce unmanaged parallelism in domain test
3575f51 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for nodejs#9979 (not a real fix).

PR-URL: nodejs#10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@joyeecheung @italoacasas
test: reduce unmanaged parallelism in domain test
62ec48c 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for nodejs#9979 (not a real fix).

PR-URL: nodejs#10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@joyeecheung @MylesBorins
test: reduce unmanaged parallelism in domain test
04ecae7 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for #9979 (not a real fix).

PR-URL: #10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@joyeecheung @MylesBorins
test: reduce unmanaged parallelism in domain test
c13f01c 
The original test lauches 10 child processes at once
and bypass `test.py`'s process regulation.
This PR reduces the unmanaged parallelism and is a
temporary workaround for #9979 (not a real fix).

PR-URL: #10329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@clarenced clarenced mentioned this pull request Mar 18, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@joyeecheung @Trott @addaleax @mscdex @MylesBorins @nodejs-github-bot