test: increase strictness for test-trace-event #11065
Conversation
mscdex
added
the
trace_events
Trott
changed the title
Change test-trace-event such that it checks that all expected values are within the same trace object rather than scattered across multiple trace objects.
| if (trace.cat !== 'v8') | ||
| return false; | ||
| if (trace.name !== 'V8.ScriptCompiler') | ||
| return false; |
There was a problem hiding this comment.
Would prefer to condense these but definitely not necessary to do so:
e.g.
return trace.pid === proc.pid &&
trace.cat === 'v8' &&
trace.name === 'V8.ScriptCompiler';There was a problem hiding this comment.
I think changing each to an assert.strictEqual() would be even better because it gives descriptive information about exactly why the throw isn't matching. Otherwise, you kind of have to figure it out.
There was a problem hiding this comment.
D'oh! No, I'm wrong, never mind. I thought this was inside an assert.throws() and not an Array.prototype.some(). Ignore my previous comment.
|
FreeBSD failure due to a stuck process and unrelated. FreeBSD CI again: https://ci.nodejs.org/job/node-test-commit-freebsd/6796/ |
|
FreeBSD CI again again: https://ci.nodejs.org/job/node-test-commit-freebsd/6816/ |
Change test-trace-event such that it checks that all expected values are within the same trace object rather than scattered across multiple trace objects. PR-URL: nodejs#11065 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 773cdc3 |
|
After #11106 land we can include this on |
Change test-trace-event such that it checks that all expected values are within the same trace object rather than scattered across multiple trace objects. PR-URL: nodejs#11065 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Change test-trace-event such that it checks that all expected values are within the same trace object rather than scattered across multiple trace objects. PR-URL: nodejs#11065 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This is dependent on #9304 which is |
Change test-trace-event such that it checks that all expected values are
within the same trace object rather than scattered across multiple trace
objects.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test