Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: validate error message from buffer.equals #11215

Closed
wants to merge 1 commit into from
Closed

test: validate error message from buffer.equals #11215

wants to merge 1 commit into from

Conversation

sebbers
Copy link

@sebbers sebbers commented Feb 7, 2017

Added a regular expressions to a throw in test/parallel/test-buffer-equals.js

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 7, 2017
@hiroppy hiroppy added the buffer Issues and PRs related to the buffer subsystem. label Feb 7, 2017
joyeecheung
joyeecheung approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the commit message to follow the guidelines, for example, something like test: validate error message from buffer.equals ? Otherwise LGTM. Thanks!

@sebbers sebbers changed the title test: add regexp as 2nd argument to throw in test-assert test: validate error message from buffer.equals Feb 7, 2017
@Trott
Copy link
Member

Trott commented Feb 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6265/

hiroppy pushed a commit to hiroppy/node that referenced this pull request Feb 11, 2017
@hiroppy
test: validate error message from buffer.equals
f8cdaaa 
Adding regular expression as an argument to an assert.throws().

PR-URL: nodejs#11215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@hiroppy
Copy link
Member

hiroppy commented Feb 11, 2017

Landed in f8cdaaa. Thanks!

@hiroppy hiroppy closed this Feb 11, 2017
@italoacasas
Copy link
Contributor

This test is failing in v7.x, any plan to backport?

@Trott
Copy link
Member

Trott commented Feb 14, 2017

In v7, the error message would be TypeError: Argument must be a Buffer. So that should be pretty easy to backport if you want to , or just don't land on 7.x.x and this will be a 8.0.0-and-later change.

krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@krydos
test: validate error message from buffer.equals
4d1b7bc 
Adding regular expression as an argument to an assert.throws().

PR-URL: nodejs#11215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@targos targos mentioned this pull request Jun 19, 2017
Closed
2 tasks
gibfahn pushed a commit that referenced this pull request Jun 19, 2017
@gibfahn
test: validate error message from buffer.equals
1e889b8 
Adding regular expression as an argument to an assert.throws().

PR-URL: #11215
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@gibfahn
test: validate error message from buffer.equals
bcfeed2 
Adding regular expression as an argument to an assert.throws().

PR-URL: #11215
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@MylesBorins
test: validate error message from buffer.equals
c309bb0 
Adding regular expression as an argument to an assert.throws().

PR-URL: #11215
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
@targos
test: validate error message from buffer.equals
917e579 
Adding regular expression as an argument to an assert.throws().

PR-URL: nodejs/node#11215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sebbers @Trott @hiroppy @italoacasas @jasnell @cjihrig @joyeecheung @gibfahn @nodejs-github-bot