Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: validate error message from buffer.equals #11215

Closed
wants to merge 1 commit into from

Conversation

@sebbers
Copy link

commented Feb 7, 2017

Added a regular expressions to a throw in test/parallel/test-buffer-equals.js

@hiroppy hiroppy added the buffer label Feb 7, 2017

@hiroppy
hiroppy approved these changes Feb 7, 2017
@cjihrig
cjihrig approved these changes Feb 7, 2017
@joyeecheung
Copy link
Member

left a comment

Can you change the commit message to follow the guidelines, for example, something like test: validate error message from buffer.equals ? Otherwise LGTM. Thanks!

@sebbers sebbers changed the title test: add regexp as 2nd argument to throw in test-assert test: validate error message from buffer.equals Feb 7, 2017

@jasnell
jasnell approved these changes Feb 7, 2017
@Trott

This comment has been minimized.

Copy link
Member

commented Feb 7, 2017

hiroppy added a commit to hiroppy/node that referenced this pull request Feb 11, 2017
test: validate error message from buffer.equals
Adding regular expression as an argument to an assert.throws().

PR-URL: nodejs#11215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@hiroppy

This comment has been minimized.

Copy link
Member

commented Feb 11, 2017

Landed in f8cdaaa. Thanks!

@hiroppy hiroppy closed this Feb 11, 2017

@italoacasas

This comment has been minimized.

Copy link
Member

commented Feb 13, 2017

This test is failing in v7.x, any plan to backport?

@Trott

This comment has been minimized.

Copy link
Member

commented Feb 14, 2017

In v7, the error message would be TypeError: Argument must be a Buffer. So that should be pretty easy to backport if you want to , or just don't land on 7.x.x and this will be a 8.0.0-and-later change.

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017
test: validate error message from buffer.equals
Adding regular expression as an argument to an assert.throws().

PR-URL: nodejs#11215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@jasnell jasnell referenced this pull request Apr 4, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 19, 2017
test: validate error message from buffer.equals
Adding regular expression as an argument to an assert.throws().

PR-URL: #11215
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
test: validate error message from buffer.equals
Adding regular expression as an argument to an assert.throws().

PR-URL: #11215
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: validate error message from buffer.equals
Adding regular expression as an argument to an assert.throws().

PR-URL: #11215
Backport-PR-URL: #13785
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.