Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix coverity UNINIT_CTOR cctest warning #12387

Closed

Conversation

@bnoordhuis
Copy link
Member

commented Apr 13, 2017

Explicitly initialize platform_ to nullptr. Coverity cannot divine
it is set and cleared by the Setup() and TearDown() methods.

cc @danbev

CI: https://ci.nodejs.org/job/node-test-pull-request/7373/

test: fix coverity UNINIT_CTOR cctest warning
Explicitly initialize `platform_` to nullptr.  Coverity cannot divine
it is set and cleared by the Setup() and TearDown() methods.
@danbev
danbev approved these changes Apr 13, 2017
@mhdawson
Copy link
Member

left a comment

LGTM

@refack refack force-pushed the nodejs:master branch to fbe946b Apr 14, 2017

jasnell added a commit that referenced this pull request Apr 18, 2017
test: fix coverity UNINIT_CTOR cctest warning
Explicitly initialize `platform_` to nullptr.  Coverity cannot divine
it is set and cleared by the Setup() and TearDown() methods.

PR-URL: #12387
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 18, 2017

Landed in 6c912a8

@jasnell jasnell closed this Apr 18, 2017

@sam-github sam-github referenced this pull request Apr 21, 2017
2 of 2 tasks complete
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
test: fix coverity UNINIT_CTOR cctest warning
Explicitly initialize `platform_` to nullptr.  Coverity cannot divine
it is set and cleared by the Setup() and TearDown() methods.

PR-URL: #12387
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Landed on v6.x-staging, LMK if that was a mistake.

gibfahn added a commit that referenced this pull request Jun 20, 2017
test: fix coverity UNINIT_CTOR cctest warning
Explicitly initialize `platform_` to nullptr.  Coverity cannot divine
it is set and cleared by the Setup() and TearDown() methods.

PR-URL: #12387
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: fix coverity UNINIT_CTOR cctest warning
Explicitly initialize `platform_` to nullptr.  Coverity cannot divine
it is set and cleared by the Setup() and TearDown() methods.

PR-URL: #12387
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.