-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: make linter targets silent #12423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't bother me personally but LGTM.
I'd be somewhat -1 on this as I often copy the linter commands when I want to edit them, e.g. to add |
@gibfahn We don't print the actual commands for many of the other targets. Even we don't print that for cpplint. As it is, I am getting the following in master
The first line is definitely not necessary, as it is simply printing the target commands. |
@thefourtheye yes, the first line should definitely go away from the output :) Not sure about the actual commands for
Hmm, I had never pay attention for it, but it is indeed inconsistent. Moreover, this output is somewhat confusing since the command comes from the
|
what @gibfahn said (I don't know much about |
I think that for each distinct thing we do, we should print something to show we entered that section. Ideally you'd get a single line that you could copy to manually run that section. Then you'd get no other output unless there were errors/warnings. Consider someone running The aim is to balance not printing excessive info with not being too opaque IMO. I think
Then I think we should print the equivalent for cpplint (unless it's massively long).
Agreed. |
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands.
1ec0468
to
2b5637e
Compare
@gibfahn I changed it to print the linter action being carried out. Now the result looks like this ➜ node git:(make-linter-silent) make lint
Running JS linter...
./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules \
benchmark lib test tools
Running C++ linter...
Total errors found: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: #12423 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 716d831 |
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: #12423 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: #12423 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: #12423 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: #12423 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: #12423 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: nodejs/node#12423 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The linter targets are printing the commands they execute on screen.
This patch reduces the noise by not printing the commands.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build
--
cc @nodejs/build