Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce sequential/test-fs-watch flakiness #1275

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

It appears that fs.watch is sometimes unable to produce watcher events on OS X in the current 10ms timeframe, leading to the test completely timing out. My tests show that 15ms seems to eliminate most of these failures, but I opted to go for 20ms to be on the safe side.

This is probably hardware dependent, and my tests were done on a 2013 MBA. CI was affected too sometimes.

@silverwind silverwind added the test Issues and PRs related to the tests. label Mar 26, 2015
@bnoordhuis
Copy link
Member

LGTM. It doesn't fix it reliably (there is a benign race with the fsevents thread going on) but it's good enough as a bandaid.

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/381/

silverwind added a commit that referenced this pull request Mar 27, 2015
The fs.watch test's write events sometimes aren't produced on OS X,
possibly because of a fsevents race condition. This patch gives delays
the writing a total of 20ms, which makes the test pass consistently.

PR-URL: #1275
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@silverwind
Copy link
Contributor Author

merged in 955c150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants