Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: describe parse err in debug output #13206

Closed
wants to merge 1 commit into from
Closed

http: describe parse err in debug output #13206

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

parse errors are fairly invisible on the server, even with NODE_DEBUG, the actuall error is not reported, just that one ocurred. This patch helped me a lot.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 24, 2017
@sam-github sam-github requested a review from mscdex May 24, 2017 20:19
@mscdex
Copy link
Contributor

mscdex commented May 24, 2017 •
edited
Loading

That's fine I suppose, you should probably add it in _http_client.js also for consistency.

@sam-github
Copy link
Contributor Author

@mscdex done

@mscdex
Copy link
Contributor

mscdex commented May 24, 2017

LGTM.

@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/8293/

jasnell pushed a commit that referenced this pull request Jun 1, 2017
@sam-github @jasnell
http: describe parse err in debug output
3fba3d6 
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell
Copy link
Member

jasnell commented Jun 1, 2017 •
edited by refack
Loading

Landed in 3ffba3d6 3fba3d6

@jasnell jasnell closed this Jun 1, 2017
@jasnell jasnell reopened this Jun 1, 2017
@jasnell jasnell closed this Jun 1, 2017
@jasnell jasnell reopened this Jun 1, 2017
@jasnell
Copy link
Member

jasnell commented Jun 1, 2017

eh... no idea what just happened right there.

@jasnell jasnell closed this Jun 1, 2017
@refack
Copy link
Contributor

refack commented Jun 1, 2017

edited commit hash

jasnell pushed a commit that referenced this pull request Jun 5, 2017
@sam-github @jasnell
http: describe parse err in debug output
b3c9bff 
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell jasnell mentioned this pull request Jun 5, 2017
Closed
@sam-github sam-github deleted the describe-parse-error branch June 14, 2017 20:35
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins
Copy link
Member

Should this be backported to v6.x?

sam-github added a commit to sam-github/node that referenced this pull request Jul 21, 2017
@sam-github
http: describe parse err in debug output
cf8045a 
PR-URL: nodejs#13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@sam-github sam-github mentioned this pull request Jul 21, 2017
Closed
4 tasks
@sam-github
Copy link
Contributor Author

@MylesBorins yes, and I did.

MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
@sam-github @MylesBorins
http: describe parse err in debug output
71e542c 
Backport-PR-URL: #14416
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Jul 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jul 31, 2017
@sam-github @MylesBorins
http: describe parse err in debug output
f66f09f 
Backport-PR-URL: #14416
PR-URL: #13206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins added a commit that referenced this pull request Aug 1, 2017
@MylesBorins
2017-08-01, Version 6.11.2 'Boron' (LTS)
f15e124 
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.

Notable Changes:

* configure:
  - add mips64el to valid_arch (Aditya Anand)
    - #13620
* crypto:
  - Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
    - #13279
    - #12402
    - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
  - upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
    - #12913
* http:
  - parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
    - #13206
  - Agent construction can now be envoked without `new` (cjihrig)
    - #12927
* zlib:
  - node will now throw an Error when zlib rejects the value of windowBits,
    instead of crashing (Alexey Orlenko)
    - #13098

PR-URL: #14356
MylesBorins added a commit that referenced this pull request Aug 1, 2017
@MylesBorins
2017-08-01, Version 6.11.2 'Boron' (LTS)
8a53897 
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.

Notable Changes:

* configure:
  - add mips64el to valid_arch (Aditya Anand)
    - #13620
* crypto:
  - Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
    - #13279
    - #12402
    - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
  - upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
    - #12913
* http:
  - parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
    - #13206
  - Agent construction can now be envoked without `new` (cjihrig)
    - #12927
* zlib:
  - node will now throw an Error when zlib rejects the value of windowBits,
    instead of crashing (Alexey Orlenko)
    - #13098

PR-URL: #14356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mscdex mscdex Awaiting requested review from mscdex

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sam-github @mscdex @jasnell @refack @MylesBorins @lpinca @cjihrig @nodejs-github-bot