Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
zlib: fix node crashing on invalid options #13098
This PR fixes the Node process crashing when constructors of classes of the
Affected core subsystem(s)
That's quite easy to do (aqrln@bf63a37), but I am not really sure about it. I actually see the point in doing so, but being able to test that any sort of failure can be caught seems to be more important, so I'm inclined to leave this PR as it is now unless others would prefer to pull either that commit or something similar to it here.
CI for the latest changes: https://ci.nodejs.org/job/node-test-pull-request/8159/