Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: for --enable-static, run only cctest #14892

Closed
wants to merge 3 commits into from
Closed

build: for --enable-static, run only cctest #14892

wants to merge 3 commits into from

Commits on Aug 21, 2017

  1. build: for --enable-static, run only cctest 

    Currently when building with --enable-static and running the test target
the following error will be reported:
Building addon
/node/test/addons/01_function_arguments/
env: ./node: No such file or directory
make[1]: *** [test/addons/.buildstamp] Error 1

Note that this is with a clean build where no prior node executable was
built.

This commit suggests only running the cctest target when --enable-static
is specified.
    @danbev
    danbev committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    f1f1e88 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2017

  1. squash: same logic for windows build 

    Running .\vcbuild.bat test static should now only run the cctest target.
    @danbev
    danbev committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    c9ef989 View commit details
    Browse the repository at this point in the history

  2. [suggestion] flipped if and skip jslint

    @refack
    refack committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    a159bfa View commit details
    Browse the repository at this point in the history