New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: rephrase wording of child_process.execSync() #14953

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@ayazhafiz
Contributor

ayazhafiz commented Aug 20, 2017

Rephrases the error thrown by child_process.execSync().

Fixes: #14944

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

doc: rephrase wording of child_process.execSync()
Rephrases the error thrown by child_process.execSync().

Fixes: #14944
@daxlab

daxlab approved these changes Aug 20, 2017

@lpinca

lpinca approved these changes Aug 20, 2017

@refack

refack approved these changes Aug 20, 2017

@refack refack self-assigned this Aug 20, 2017

jasnell added a commit that referenced this pull request Aug 23, 2017

doc: rephrase text of child_process.execSync()
Rephrases the error thrown by child_process.execSync().

PR-URL: #14953
Fixes: #14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 23, 2017

Member

Landed in e76b1ff

Member

jasnell commented Aug 23, 2017

Landed in e76b1ff

@jasnell jasnell closed this Aug 23, 2017

@refack refack removed their assignment Aug 23, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

doc: rephrase text of child_process.execSync()
Rephrases the error thrown by child_process.execSync().

PR-URL: nodejs/node#14953
Fixes: nodejs/node#14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

doc: rephrase text of child_process.execSync()
Rephrases the error thrown by child_process.execSync().

PR-URL: nodejs/node#14953
Fixes: nodejs/node#14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

doc: rephrase text of child_process.execSync()
Rephrases the error thrown by child_process.execSync().

PR-URL: #14953
Fixes: #14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

doc: rephrase text of child_process.execSync()
Rephrases the error thrown by child_process.execSync().

PR-URL: #14953
Fixes: #14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

doc: rephrase text of child_process.execSync()
Rephrases the error thrown by child_process.execSync().

PR-URL: #14953
Fixes: #14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment