Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix indentation in node.gyp #15051

Closed
wants to merge 1 commit into from
Closed

build: fix indentation in node.gyp #15051

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Aug 27, 2017

One line in node.gyp was indented using a mix of a tab and spaces,
convert it to all spaces.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@aqrln
build: fix indentation in node.gyp
d403f6e 
One line in node.gyp was indented using a mix of a tab and spaces,
convert it to all spaces.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 27, 2017
@aqrln
Copy link
Contributor Author

aqrln commented Aug 27, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9849/

@refack refack added the python PRs and issues that require attention from people who are familiar with Python. label Aug 27, 2017
@jasnell
Copy link
Member

jasnell commented Aug 29, 2017 •
edited
Loading

This likely doesn't need to wait 48 hours ... ha! it already did

jasnell pushed a commit that referenced this pull request Aug 29, 2017
@aqrln @jasnell
build: fix indentation in node.gyp
689a643 
One line in node.gyp was indented using a mix of a tab and spaces,
convert it to all spaces.

PR-URL: #15051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 29, 2017

Landed in 689a643

@jasnell jasnell closed this Aug 29, 2017
@aqrln aqrln deleted the tab-to-spaces-node.gyp branch August 29, 2017 11:26
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@aqrln
build: fix indentation in node.gyp
9b7228c 
One line in node.gyp was indented using a mix of a tab and spaces,
convert it to all spaces.

PR-URL: nodejs/node#15051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@aqrln
build: fix indentation in node.gyp
9a04c3f 
One line in node.gyp was indented using a mix of a tab and spaces,
convert it to all spaces.

PR-URL: nodejs/node#15051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@aqrln @cjihrig
build: fix indentation in node.gyp
81dfcc4 
One line in node.gyp was indented using a mix of a tab and spaces,
convert it to all spaces.

PR-URL: nodejs#15051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@aqrln @MylesBorins
build: fix indentation in node.gyp
c2cbf8c 
One line in node.gyp was indented using a mix of a tab and spaces,
convert it to all spaces.

PR-URL: #15051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@aqrln @MylesBorins
build: fix indentation in node.gyp
b946693 
One line in node.gyp was indented using a mix of a tab and spaces,
convert it to all spaces.

PR-URL: #15051
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxlab daxlab daxlab approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aqrln @jasnell @refack @danbev @lpinca @cjihrig @hiroppy @daxlab @MylesBorins @nodejs-github-bot