test: implement common.skipIfNoIpv6Localhost #16248

joyeecheung · 2017-10-17T04:53:12Z

Refs: #15936 (comment)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

joyeecheung · 2017-10-17T05:52:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10770/

joyeecheung · 2017-10-17T10:39:24Z

Fixed lint errors. New CI: https://ci.nodejs.org/job/node-test-pull-request/10779/

cc @nodejs/testing

mhdawson

LGTM

maclover7 · 2017-11-03T19:10:21Z

Nit: should this change to be a skipIf function like skipIf32Bits and skipIfInspectorDisabled? Mostly just to fit to the same style.

joyeecheung · 2017-11-04T03:54:07Z

@maclover7 Yeah that's what I originally named this..I think at that point I thought the semantics of this did not align with other skipIf* functions but now looking at it again I don't find any problems? Anyway I'll rebase and rename it.

joyeecheung · 2017-11-06T13:03:48Z

@mhdawson @maclover7 Rebased and renamed , PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/11211/

maclover7 · 2017-11-06T14:35:55Z

LGTM

joyeecheung · 2017-11-08T10:36:24Z

This is failing on raspberry pis since they don't have ipv6 support and the tests mustCall the callbacks. I'll fix it.

joyeecheung · 2017-11-11T08:04:35Z

Removed the common.mustCall since uh...the point of this PR is to skip the callbacks when ipv6 localhost is not available...¯\(ツ)/¯

CI: https://ci.nodejs.org/job/node-test-pull-request/11354/

Which run the callback with a local host that can be resolved to ::1 if available, otherwise skip the test.

joyeecheung · 2017-11-12T11:40:40Z

Rebased. New CI: https://ci.nodejs.org/job/node-test-pull-request/11372/

refack · 2017-11-12T14:10:06Z

test/parallel/test-https-connect-address-family.js

@@ -20,7 +19,7 @@ function runTest() {
    res.end();
  })).listen(0, '::1', common.mustCall(function() {
    const options = {
-      host: 'localhost',
+      host: ipv6Host,


given that // This test that the family option of https.get is honored. would it be correct to replace this with '::1' since this what the server bind to?

@refack I think replacing it with a ip would skip the family option handling altogether. The family option is used when performing a lookup, so if the connection doesn't even need to lookup then it won't be tested. In net.js:

// If host is an IP, skip performing a lookup var addressType = cares.isIP(host); if (addressType) { nextTick(self[async_id_symbol], function() { if (self.connecting) internalConnect(self, host, port, addressType, localAddress, localPort); }); return; } .... var dnsopts = { family: options.family, hints: options.hints || 0 };

refack

Let's think is this is not overkill?

refack · 2017-11-12T14:15:09Z

Let's think is this is not overkill?

AFAICT those two test can skip the DNS calls, so if they work with '::1' I's rather have that.
(the working assumption is that the test harness should be K.I.S.S. as much as possible.)

joyeecheung · 2017-11-12T15:34:50Z

@refack

AFAICT those two test can skip the DNS calls, so if they work with '::1' I's rather have that.
(the working assumption is that the test harness should be K.I.S.S. as much as possible.)

Uh..those tests are testing DNS calls, family is passed to the lookup function.

Use common.skipIfNoIpv6Localhost

joyeecheung · 2017-11-12T15:39:24Z

Ah, forgot to run the linter...also the arm compilation seems to be having a outage?

refack · 2017-11-12T17:40:12Z

Uh..those tests are testing DNS calls, family is passed to the lookup function.

I want to dig into that. let's see if we can refactor something around this.

joyeecheung · 2017-11-15T06:06:33Z

Closing in favor of #16976

PR-URL: nodejs#16976 Refs: nodejs#16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #16976 Refs: #16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: nodejs#16976 Refs: nodejs#16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Backport-PR-URL: #21736 PR-URL: #16976 Refs: #16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 17, 2017

joyeecheung requested a review from mhdawson October 17, 2017 04:53

joyeecheung force-pushed the skip-localhost-ipv6 branch from cb51f1d to 3160827 Compare October 17, 2017 10:37

mhdawson reviewed Nov 3, 2017

View reviewed changes

joyeecheung mentioned this pull request Nov 4, 2017

todo: account LGTM in "COMMENTED" reviews nodejs/node-core-utils#67

Closed

Tiriel mentioned this pull request Nov 4, 2017

Fixing review state to APPROVED whe 'LGTM' in COMMENTED review nodejs/node-core-utils#72

Merged

joyeecheung force-pushed the skip-localhost-ipv6 branch 2 times, most recently from f0726ae to bbeab1a Compare November 6, 2017 13:02

joyeecheung changed the title ~~test: implement common.runIfHasIpv6Localhost~~ test: implement common.skipIfNoIpv6Localhost Nov 6, 2017

jasnell approved these changes Nov 8, 2017

View reviewed changes

joyeecheung added the wip Issues and PRs that are still a work in progress. label Nov 8, 2017

joyeecheung removed the wip Issues and PRs that are still a work in progress. label Nov 11, 2017

test: implement common.skipIfNoIpv6Localhost

fe78073

Which run the callback with a local host that can be resolved to ::1 if available, otherwise skip the test.

joyeecheung force-pushed the skip-localhost-ipv6 branch from caffada to 92af228 Compare November 12, 2017 11:39

refack reviewed Nov 12, 2017

View reviewed changes

refack suggested changes Nov 12, 2017

View reviewed changes

joyeecheung added 2 commits November 12, 2017 23:38

test: make the https connect test more robust

c3c6540

Use common.skipIfNoIpv6Localhost

test: refactor net.connect ipv6 options test

8097bd8

Use common.skipIfNoIpv6Localhost

joyeecheung force-pushed the skip-localhost-ipv6 branch from 92af228 to 8097bd8 Compare November 12, 2017 15:38

refack mentioned this pull request Nov 12, 2017

test: bypass dns for IPv6 net tests #16976

Merged

3 tasks

joyeecheung closed this Nov 15, 2017

refack added a commit to refack/node that referenced this pull request Nov 21, 2017

test: bypass dns for IPv6 net tests

283b949

PR-URL: nodejs#16976 Refs: nodejs#16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017

test: bypass dns for IPv6 net tests

6a0cb94

PR-URL: #16976 Refs: #16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017

test: bypass dns for IPv6 net tests

c2bb4b2

PR-URL: #16976 Refs: #16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

BethGriggs mentioned this pull request Jul 10, 2018

[v8.x backport] test: bypass dns for IPv6 net tests #21736

Closed

2 tasks

BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Jul 10, 2018

test: bypass dns for IPv6 net tests

38847dd

PR-URL: nodejs#16976 Refs: nodejs#16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins pushed a commit that referenced this pull request Aug 1, 2018

test: bypass dns for IPv6 net tests

1d3ea3f

Backport-PR-URL: #21736 PR-URL: #16976 Refs: #16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

rvagg pushed a commit that referenced this pull request Aug 16, 2018

test: bypass dns for IPv6 net tests

9a9ea0d

Backport-PR-URL: #21736 PR-URL: #16976 Refs: #16248 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: implement common.skipIfNoIpv6Localhost #16248

test: implement common.skipIfNoIpv6Localhost #16248

joyeecheung commented Oct 17, 2017

joyeecheung commented Oct 17, 2017

joyeecheung commented Oct 17, 2017

mhdawson left a comment

maclover7 commented Nov 3, 2017

joyeecheung commented Nov 4, 2017

joyeecheung commented Nov 6, 2017

maclover7 commented Nov 6, 2017

joyeecheung commented Nov 8, 2017

joyeecheung commented Nov 11, 2017 •

edited

Loading

joyeecheung commented Nov 12, 2017

refack Nov 12, 2017

joyeecheung Nov 12, 2017 •

edited

Loading

refack left a comment

refack commented Nov 12, 2017

joyeecheung commented Nov 12, 2017 •

edited

Loading

joyeecheung commented Nov 12, 2017 •

edited

Loading

refack commented Nov 12, 2017

joyeecheung commented Nov 15, 2017 •

edited

Loading

test: implement common.skipIfNoIpv6Localhost #16248

test: implement common.skipIfNoIpv6Localhost #16248

Conversation

joyeecheung commented Oct 17, 2017

Checklist

Affected core subsystem(s)

joyeecheung commented Oct 17, 2017

joyeecheung commented Oct 17, 2017

mhdawson left a comment

Choose a reason for hiding this comment

maclover7 commented Nov 3, 2017

joyeecheung commented Nov 4, 2017

joyeecheung commented Nov 6, 2017

maclover7 commented Nov 6, 2017

joyeecheung commented Nov 8, 2017

joyeecheung commented Nov 11, 2017 • edited Loading

joyeecheung commented Nov 12, 2017

refack Nov 12, 2017

Choose a reason for hiding this comment

joyeecheung Nov 12, 2017 • edited Loading

Choose a reason for hiding this comment

refack left a comment

Choose a reason for hiding this comment

refack commented Nov 12, 2017

joyeecheung commented Nov 12, 2017 • edited Loading

joyeecheung commented Nov 12, 2017 • edited Loading

refack commented Nov 12, 2017

joyeecheung commented Nov 15, 2017 • edited Loading

joyeecheung commented Nov 11, 2017 •

edited

Loading

joyeecheung Nov 12, 2017 •

edited

Loading

joyeecheung commented Nov 12, 2017 •

edited

Loading

joyeecheung commented Nov 12, 2017 •

edited

Loading

joyeecheung commented Nov 15, 2017 •

edited

Loading