test: fixtures module replaced fixturesDir

[tpurcell]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test

[BridgeAR]

This should use the readKey function instead.

[jasnell]

For instance,

key: fixtures.readKey('agent2-key.pem'),
cert: fixtures.readKey('agent2-cert.pem')

[tpurcell]

Sorry to have gone dead on this. I'm obviously new to this and I've run into an issue.
When I submitted the PR all tests were passing. Today I:

• Pulled from master to get my local repo up to date
• Rebuilt node
• Ran tests

git pull https://github.com/nodejs/node.git master
./configure 
make -j4
make test

I'm getting failed tests now:

ath: parallel/test-https-connect-address-family
/home/tpurcell/data/mycode/node/node/test/parallel/test-https-connect-address-family.js:39
    throw err;
    ^
Error: getaddrinfo EAI_AGAIN
    at Object._errnoException (util.js:1023:13)
    at errnoException (dns.js:63:15)
    at GetAddrInfoReqWrap.onlookupall [as oncomplete] (dns.js:112:26)
Command: out/Release/node /home/tpurcell/data/mycode/node/node/test/parallel/test-https-connect-address-family.js

I don't see a connection between this error and the code I should be changing. Like I said the tests ran clean before the pull from master and I've made no other local changes.

Questions:

• Is there a way to find out the state of the current canonical build? If I could check that it would tell me if its just an issue with my local repo.
• Am I making some perfectly obvious rookie mistake.

Thanks for the help

[joyeecheung]

Looks like you have done some git merge on this branch, the best way to keep a PR up-to-date is to use git rebase instead (see the contributing guide)

On the error thrown by parallel/test-https-connect-address-family, that seems unrelated to this test so you could probabaly just ignore that . Judging from the message, looks like your machine timed out on resolving localhost to ::1, which that file should probably address by adding EAI_AGAIN on line 36..so yeah, this is probably an oversight of that test.

[tpurcell]

Thanks for the response. After posting I did a completely fresh git clone of master and got the same errors so I figured it was something outside test-https-client-resume.

Thanks for the tip on rebase. I'll get my local checkout straight and then resubmit the PR.

Appreciate the help.

[joyeecheung]

Ping @tpurcell

[joyeecheung]

Superseded by #16262