http2: fix kUpdateTimer timer refresh #18062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
timers
nodejs-github-bot
added
dont-land-on-v4.x
http2
Fishrock123
force-pushed
the
fix-93eb68e
branch
from
4fe0b9a
to
108b1a6
Compare
jasnell
approved these changes
Jan 9, 2018
|
timeouts are definitely one area where we need more test coverage for http2. It's been on my list, just haven't been able to get to it yet. |
cjihrig
approved these changes
Jan 9, 2018
Fishrock123
changed the title
lpinca
approved these changes
Jan 10, 2018
Fishrock123
force-pushed
the
fix-93eb68e
branch
from
108b1a6
to
11b17dd
Compare
|
CI before landing: https://ci.nodejs.org/job/node-test-pull-request/12503/ |
Fixes an oversight from 93eb68e Wasn't caught by a test. PR-URL: nodejs#18062 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123
force-pushed
the
fix-93eb68e
branch
from
11b17dd
to
0812ebd
Compare
|
This is not landing cleanly on v9.x-staging. If you would like to see this land in v9.x, can you please submit a backport PR? Thanks! |
3 tasks
|
This is based on a semver-major PR. So I added the do not land labels. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight from 93eb68e 😬
Wasn't caught by a test... @nodejs/http2 anyone have suggestions on how to write a test? Or if you want to write one and push it here that would be fine too.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (Unfortunately)Affected core subsystem(s)
http2