Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: runtime-deprecate {un}enroll() #18066

Merged
merged 1 commit into from
Feb 2, 2018

Commits on Feb 2, 2018

  1. timers: runtime-deprecate {un}enroll()

    This was never a Very Good API, and generally just left so many open
    ends for inconsistent behavior. The "optimization" benefit of this API
    is little to none. Makes a starting step towards removing it so that in
    the future timers, especially in their async_hooks interactions, can be
    simplified.
    
    PR-URL: nodejs#18066
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Fishrock123 committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    68783ae View commit details
    Browse the repository at this point in the history