src: fix compiler warning about deprecated api #18390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
The `GetCpuProfiler()` api has been deprecated and it is advised to use the `CpuProfiler::New` call instead. This PR refactors to code causing the warning using a pattern found within in the V8 codebase.
MylesBorins
force-pushed
the
fix-compiler-warning
branch
from
c712782
to
c08e758
Compare
|
See discussion in #18039. It seems to be more complicated than this. |
|
As well, instantiating a new profiler every tick leaks memory like a sieve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetCpuProfiler()api has been deprecated and it is advised touse the
CpuProfiler::Newcall instead. This PR refactors to codecausing the warning using a pattern found within in the V8 codebase.