Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: improve write(U)Int functions #19289

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This improves the performance of some buffer write functions.

 buffers/buffer-write.js millions=5 type='Int32BE' buffer='fast'         ***      5.83 %       ±1.13% ±1.51% ±1.97%
 buffers/buffer-write.js millions=5 type='Int32BE' buffer='slow'         ***      6.40 %       ±3.04% ±4.05% ±5.30%
 buffers/buffer-write.js millions=5 type='Int32LE' buffer='fast'         ***     11.19 %       ±1.90% ±2.54% ±3.32%
 buffers/buffer-write.js millions=5 type='Int32LE' buffer='slow'         ***     13.35 %       ±2.47% ±3.28% ±4.28%
 buffers/buffer-write.js millions=5 type='IntBE' buffer='fast'                   -0.36 %       ±1.59% ±2.12% ±2.76%
 buffers/buffer-write.js millions=5 type='IntBE' buffer='slow'                    0.15 %       ±0.97% ±1.29% ±1.67%
 buffers/buffer-write.js millions=5 type='IntLE' buffer='fast'                    1.68 %       ±2.23% ±2.98% ±3.92%
 buffers/buffer-write.js millions=5 type='IntLE' buffer='slow'                    0.31 %       ±1.34% ±1.78% ±2.31%
 buffers/buffer-write.js millions=5 type='UInt32BE' buffer='fast'        ***      7.28 %       ±1.42% ±1.89% ±2.47%
 buffers/buffer-write.js millions=5 type='UInt32BE' buffer='slow'        ***      7.66 %       ±1.49% ±1.99% ±2.59%
 buffers/buffer-write.js millions=5 type='UInt32LE' buffer='fast'        ***      3.53 %       ±1.04% ±1.38% ±1.80%
 buffers/buffer-write.js millions=5 type='UInt32LE' buffer='slow'        ***      5.49 %       ±2.12% ±2.84% ±3.74%
 buffers/buffer-write.js millions=5 type='UIntBE' buffer='fast'                   0.76 %       ±2.48% ±3.32% ±4.36%
 buffers/buffer-write.js millions=5 type='UIntBE' buffer='slow'                   0.35 %       ±3.25% ±4.34% ±5.66%
 buffers/buffer-write.js millions=5 type='UIntLE' buffer='fast'                  -1.21 %       ±2.70% ±3.63% ±4.78%
 buffers/buffer-write.js millions=5 type='UIntLE' buffer='slow'                   1.50 %       ±2.20% ±2.96% ±3.92%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This improves the performance of some write functions by around 5-15%.
@nodejs-github-bot nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Mar 11, 2018
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2018
@tniessen
Copy link
Member

@lpinca
Copy link
Member

lpinca commented Mar 24, 2018

Landed in f4e5f96.

lpinca pushed a commit that referenced this pull request Mar 24, 2018
This improves the performance of some write functions by around 5-15%.

PR-URL: #19289
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca closed this Mar 24, 2018
@targos targos added dont-land-on-v9.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 2, 2018
@BridgeAR BridgeAR deleted the improve-buffer-write branch April 1, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants