Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.5.254.43 #19615

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.5.254.43 #19615

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Mar 26, 2018
@MylesBorins
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13875/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1285/

targos
targos approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 26, 2018
@MylesBorins
Copy link
Contributor Author

Adding fast track as this one simply bumps the version number (patch applied then reverted)

@MylesBorins
Copy link
Contributor Author

b3f2391

MylesBorins added a commit that referenced this pull request Mar 27, 2018
@MylesBorins
deps: patch V8 to 6.5.254.43
b3f2391 
PR-URL: #19615
Refs: v8/v8@6.5.254.41...6.5.254.43
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Leko Leko Leko approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MylesBorins @Leko @targos @cjihrig @nodejs-github-bot