Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: sort ENVIRONMENT_STRONG_PERSISTENT_PROPERTIES #19627

Closed
wants to merge 1 commit into from
Closed

src: sort ENVIRONMENT_STRONG_PERSISTENT_PROPERTIES #19627

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Mar 27, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 27, 2018
@danbev
Copy link
Contributor Author

danbev commented Mar 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13882/

@danbev
Copy link
Contributor Author

danbev commented Mar 29, 2018

node-test-commit failure looks unrelated

console output:

02:06:28 not ok 1267 parallel/test-process-redirect-warnings-env
02:06:28   ---
02:06:28   duration_ms: 0.409
02:06:28   severity: fail
02:06:28   stack: |-
02:06:28   ...

danbev added a commit that referenced this pull request Mar 29, 2018
@danbev
src: sort ENVIRONMENT_STRONG_PERSISTENT_PROPERTIES
852ba3a 
PR-URL: #19627
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented Mar 29, 2018

Landed in 852ba3a.

@danbev danbev closed this Mar 29, 2018
@danbev danbev deleted the sort_env_strong_persistent_properties branch March 29, 2018 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@danbev @jasnell @TimothyGu @cjihrig @gibfahn @addaleax @targos @nodejs-github-bot