Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.x backport] console: add table method #19750

Closed
wants to merge 1 commit into from

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Apr 2, 2018

PR-URL: #18137
Reviewed-By: Tiancheng "Timothy" Gu timothygu99@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

PR-URL: nodejs#18137
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. console Issues and PRs related to the console subsystem. v9.x labels Apr 2, 2018
@devsnek
Copy link
Member Author

devsnek commented Apr 2, 2018

@devsnek
Copy link
Member Author

devsnek commented Apr 2, 2018

/cc @bnoordhuis as internal/v8 is missing should i just use runInDebugContext and mirror.preview? the version of v8 in the 9.x branch also has %MapIteratorClone and %SetIteratorClone so i think i can also backport internal/v8 in?

@devsnek devsnek closed this Apr 22, 2018
@devsnek devsnek deleted the backport-18137-to-v9.x branch April 22, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. console Issues and PRs related to the console subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants