lib: make c, ca and certs const in _tls_common #20073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyGu
reviewed
Apr 16, 2018
lib/_tls_common.js
Outdated
| var i; | ||
| var val; | ||
|
|
||
| if (context) return c; | ||
|
|
||
| // NOTE: It's important to add CA before the cert to be able to load | ||
| // cert's issuer in C++ code. | ||
| var ca = options.ca; | ||
| const ca = options.ca; |
There was a problem hiding this comment.
Use destructuring here and for cert?
There was a problem hiding this comment.
Yeah, that sounds good. I'll update. Thx
trivikr
approved these changes
Apr 17, 2018
jasnell
approved these changes
Apr 17, 2018
|
Landed in 188ed07 |
danbev
added a commit
that referenced
this pull request
Apr 19, 2018
PR-URL: #20073 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
PR-URL: #20073 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes