Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix misplaced entries in test/common doc #20117

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 18, 2018

One entry is placed in the wrong module and other entries are not in
alphabetical order.

Checklist

One entry is placed in the wrong module and other entries are not in
alphabetical order.
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 18, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 18, 2018
@Trott
Copy link
Member Author

Trott commented Apr 18, 2018

Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for fast-track

@vsemozhetbyt
Copy link
Contributor

CI was aborted, new CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/545/

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 18, 2018
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to fast track

Trott added a commit to Trott/io.js that referenced this pull request Apr 18, 2018
One entry is placed in the wrong module and other entries are not in
alphabetical order.

PR-URL: nodejs#20117
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@Trott
Copy link
Member Author

Trott commented Apr 18, 2018

Landed in 5249152

@Trott Trott closed this Apr 18, 2018
jasnell pushed a commit that referenced this pull request Apr 19, 2018
One entry is placed in the wrong module and other entries are not in
alphabetical order.

PR-URL: #20117
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@Trott Trott deleted the fix-doc-ordering branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants