Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update non-string header names should throw #20172

Closed
wants to merge 1 commit into from
Closed

test: update non-string header names should throw #20172

wants to merge 1 commit into from

Conversation

dhanushuUzumaki
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 20, 2018
addaleax
addaleax approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the commit message so that it starts with test: rather than src:?

(If you’re not sure how, git commit --amend && git push --force-with-lease should let you update the message to anything you want.)

@addaleax addaleax added the http Issues or PRs related to the http subsystem. label Apr 20, 2018
@dhanushuUzumaki
Copy link
Contributor Author

Updated 😄 .

@BridgeAR BridgeAR changed the title src: update non-string header names should throw test: update non-string header names should throw Apr 20, 2018
@addaleax
Copy link
Member

Thanks!

CI: https://ci.nodejs.org/job/node-test-commit/17900/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2018
trivikr pushed a commit that referenced this pull request Apr 23, 2018
@dhanushuUzumaki @trivikr
test: update non-string header names should throw
1c66a10 
PR-URL: #20172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@trivikr
Copy link
Member

trivikr commented Apr 23, 2018

Landed in 1c66a10

Congratulations @dhanushuUzumaki on your first commit in Node.js core! 🎉🎉🎉

@trivikr trivikr closed this Apr 23, 2018
jasnell pushed a commit that referenced this pull request Apr 23, 2018
@dhanushuUzumaki @jasnell
test: update non-string header names should throw
bb3ead8 
PR-URL: #20172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dhanushuUzumaki @addaleax @trivikr @jasnell @TimothyGu @cjihrig @ryzokuken @nodejs-github-bot