Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: use new OpenSSL constants in CipherBase #20339

Conversation

tniessen
Copy link
Member

This change replaces some constants with better alternatives which were unavailable in OpenSSL 1.0.2.

Refs: #19794
Refs: #18138

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This change replaces some constants with better alternatives which were
unavailable in OpenSSL 1.0.2.

Refs: nodejs#19794
Refs: nodejs#18138
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Apr 26, 2018
@tniessen
Copy link
Member Author

cc @nodejs/crypto

@richardlau
Copy link
Member

Setting dont-land-on-* labels based on the version of OpenSSL in the LTS release lines.

@tniessen
Copy link
Member Author

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2018
@tniessen
Copy link
Member Author

@tniessen
Copy link
Member Author

Landed in 0e63724.

tniessen added a commit that referenced this pull request Apr 30, 2018
This change replaces some constants with better alternatives which were
unavailable in OpenSSL 1.0.2.

PR-URL: #20339
Refs: #19794
Refs: #18138
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen tniessen closed this May 1, 2018
MylesBorins pushed a commit that referenced this pull request May 4, 2018
This change replaces some constants with better alternatives which were
unavailable in OpenSSL 1.0.2.

PR-URL: #20339
Refs: #19794
Refs: #18138
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants