Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: make test_error functions static #20373

Closed
wants to merge 1 commit into from
Closed

n-api: make test_error functions static #20373

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Apr 27, 2018
mhdawson
mhdawson approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/14601/

@gabrielschulhof
Copy link
Contributor Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/14627/

@gabrielschulhof
Copy link
Contributor Author

And another CI, because I rebased: https://ci.nodejs.org/job/node-test-pull-request/14657/

@gabrielschulhof
Copy link
Contributor Author

Landed in cd8ed1c.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request May 4, 2018
n-api: make test_error functions static
cd8ed1c 
PR-URL: nodejs#20373
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof gabrielschulhof deleted the n-api-make-test-error-static branch May 4, 2018 02:55
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@MylesBorins
n-api: make test_error functions static
d329778 
PR-URL: #20373
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@MylesBorins
n-api: make test_error functions static
17dbf6c 
PR-URL: #20373
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielschulhof @cjihrig @mhdawson @nodejs-github-bot