doc: fix typo in n-api.md #21060
Closed
doc: fix typo in n-api.md #21060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just replaced `than` with `that`. - wrong: the N-API functions than can be used to change - correct: the N-API functions that can be used to change Fixes: nodejs#21049
nodejs-github-bot
added
doc
trivikr
approved these changes
May 31, 2018
trivikr
added
the
author ready
Trott
approved these changes
May 31, 2018
vsemozhetbyt
added
the
fast-track
vsemozhetbyt
approved these changes
May 31, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
|
CI-lite rerun: https://ci.nodejs.org/job/node-test-pull-request-lite/776/ |
|
LinuxONE has 7 build failures in a row. Looks like we'll need @nodejs/build to take a look. |
|
I see why it's broken. I'll fix it in a moment. |
|
CI is green but failed to update indicators in the PR. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 31, 2018
just replaced `than` with `that`. - wrong: the N-API functions than can be used to change - correct: the N-API functions that can be used to change Fixes: nodejs#21049 PR-URL: nodejs#21060 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
|
Landed in dcecfb7 |
|
Thanks for your quick review. |
addaleax
pushed a commit
that referenced
this pull request
Jun 1, 2018
just replaced `than` with `that`. - wrong: the N-API functions than can be used to change - correct: the N-API functions that can be used to change Fixes: #21049 PR-URL: #21060 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just replaced
thanwiththatas suggested in #21049.Fixes: #21049
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes