Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: log before and after RSS in memory leak test #21080

Closed
wants to merge 2 commits into from
Closed

test: log before and after RSS in memory leak test #21080

wants to merge 2 commits into from

Commits on Jun 2, 2018

  1. test: log before and after RSS in memory leak test 

    Refs: nodejs#21076
    @bnoordhuis
    bnoordhuis committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    cb3989f View commit details
    Browse the repository at this point in the history

  2. test: increase slop limit in memory leak test 

    It transpires that the extra bookkeeping in debug builds sometimes makes
the increase in RSS go _just_ over the 5 MB limit, by fewer than 100 kB.
Double the limit so we hopefully don't run into it any time again soon.

The memory leak it tests for was one where RSS grew by hundreds of
megabytes over the lifetime of the test; 5 vs. 10 MB is insignificant.

Fixes: nodejs#21076
    @bnoordhuis
    bnoordhuis committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    1569bf4 View commit details
    Browse the repository at this point in the history