Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix debugging for multiple categories #21422

Closed
wants to merge 1 commit into from
Closed

src: fix debugging for multiple categories #21422

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Fix parsing of e.g. NODE_DEBUG_NATIVE=worker,messaging.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: fix debugging for multiple categories
939820c 
Fix parsing of e.g. `NODE_DEBUG_NATIVE=worker,messaging`.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/104/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 20, 2018
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 20, 2018
@addaleax
Copy link
Member Author

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15535/

Feel free to 👍 this for fast-tracking.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2018
@Trott
Copy link
Member

Trott commented Jun 20, 2018

CI re-run to see if AIX is clear now: https://ci.nodejs.org/job/node-test-pull-request/15539/

@addaleax
Copy link
Member Author

Landed in 7aa9567

@addaleax addaleax closed this Jun 20, 2018
@addaleax addaleax deleted the debug-multiple branch June 20, 2018 20:49
addaleax added a commit that referenced this pull request Jun 20, 2018
@addaleax
src: fix debugging for multiple categories
7aa9567 
Fix parsing of e.g. `NODE_DEBUG_NATIVE=worker,messaging`.

PR-URL: #21422
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jun 22, 2018
@addaleax @targos
src: fix debugging for multiple categories
2377aec 
Fix parsing of e.g. `NODE_DEBUG_NATIVE=worker,messaging`.

PR-URL: #21422
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @Trott @cjihrig @BridgeAR