Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add worker prefix to test-message* tests #21512

Closed
wants to merge 1 commit into from
Closed

test: add worker prefix to test-message* tests #21512

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 24, 2018

It makes it easier to locate all tests related to the worker subsystem.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/148/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 24, 2018
@targos targos added the worker Issues and PRs related to Worker support. label Jun 24, 2018
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2018
@trivikr
Copy link
Member

trivikr commented Jun 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15604/

@targos
test: add worker prefix to test-message* tests
bdcb272 
It makes it easier to locate all tests related to the worker subsystem.
@targos
Copy link
Member Author

targos commented Jun 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15688/

@targos
Copy link
Member Author

targos commented Jun 30, 2018

Landed in b87b164

@targos targos closed this Jun 30, 2018
@targos targos deleted the move-worker-tests branch June 30, 2018 16:26
targos added a commit that referenced this pull request Jun 30, 2018
@targos
test: add worker prefix to test-message* tests
b87b164 
It makes it easier to locate all tests related to the worker subsystem.

PR-URL: #21512
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
targos added a commit that referenced this pull request Jul 3, 2018
@targos
test: add worker prefix to test-message* tests
95fa3c6 
It makes it easier to locate all tests related to the worker subsystem.

PR-URL: #21512
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@JungMinu JungMinu JungMinu approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @trivikr @jasnell @lpinca @TimothyGu @cjihrig @hiroppy @JungMinu