Test fix #22487
Test fix #22487
Conversation
|
@abelmark can you please rebase against master and remove the merge commit? Thank you. |
There was a problem hiding this comment.
LGTM after @lpinca comment is addressed.
Also, @abelmark you don't have you name/email set up correctly in git (github didn't recognize you as the author of the commit), so if you want to have 'contributor' github badge I'd reccomend you to do that (see https://help.github.com/articles/setting-your-username-in-git/)
|
I believe I set it up... the article you listed said that Git username is not the same as your Github identity... so I just put it as my full name. Will I still receive the contribution badge? |
test/parallel/test-util-log.js
Outdated
| @@ -62,4 +62,5 @@ tests.forEach(function(test) { | |||
|
|
|||
| assert.strictEqual(process.stdout.writeTimes, tests.length); | |||
|
|
|||
| restoreStdout(); | |||
| common.restoreStdout(); | |||
| common.restoreStderr(); | |||
There was a problem hiding this comment.
nit: newline at the end of the file
There was a problem hiding this comment.
@Trott this has to be: restoreStdout() and restoreStderr(). So the common. part has to be removed on both. restoreStderr has to be destructured along the other parts.
There was a problem hiding this comment.
@BridgeAR I didn't author any code. All I did here was add a missing newline at end of file. (I should have been more explicit about that in my previous comment.)
|
@abelmark sorry, I thought the link included both name and email. I think your local git-config email doesn't match the one on github. Here is the link: https://help.github.com/articles/setting-your-commit-email-address-in-git/ |
addaleax
added
the
author ready
There was a problem hiding this comment.
@abelmark Appropriate functions (restoreStdout, restoreStderr) are in common/hijackstdio. See https://github.com/nodejs/node/blob/master/test/parallel/test-util-log.js#L28. They are not present in the usual require('../common').
lundibundi
removed
the
author ready
There was a problem hiding this comment.
CI shows this breaking, for the reasons cited by @BridgeAR in #22487 (comment) and @lundibundi in #22487 (review). @abelmark Are you able to fix it the way they describe?
|
Ping @abelmark |
bb29405 lib,src: fix consistent spacing inside braces 76340e3 test: fix RegExp nits d00e5f1 test: add hijackStdout and hijackStderr 98e54b0 meta: restore original copyright header 3d2aef3 test: s/assert.equal/assert.strictEqual/ 7a0e462 test: use eslint to fix var->const/let ff1efa6 test: use const for all require() calls 9940766 test: fix tests after V8 upgrade d1aabd6 test: fix style issues after eslint update 02fe821 test: load common.js to test for global leaks e3f9335 tools: re-enable comma-spacing linter rule f29762f test: enable linting for tests 3e1b1dd Remove excessive copyright/license boilerplate 0e19476 test: split test in parallel/sequential Fixes: #22472
|
Rebased and fixed the issue to get this going. |
|
Landed in ed35df7, thanks for the PR! 🎉 |
Fixes: #22472 Co-authored-by: Denys Otrishko <shishugi@gmail.com> PR-URL: #22487 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #22472 Co-authored-by: Denys Otrishko <shishugi@gmail.com> PR-URL: #22487 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #22472
Checklist