Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update onboarding task #23300

Closed
wants to merge 1 commit into from
Closed

doc: update onboarding task #23300

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 6, 2018

Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.

👍 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 6, 2018
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 6, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.
Trott added a commit to Trott/io.js that referenced this pull request Oct 7, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.

PR-URL: nodejs#23300
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 7, 2018

Landed in 061e098

@Trott Trott closed this Oct 7, 2018
targos pushed a commit that referenced this pull request Oct 7, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.

PR-URL: #23300
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.

PR-URL: #23300
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sagitsofan pushed a commit to sagitsofan/node that referenced this pull request Oct 12, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.

PR-URL: nodejs#23300
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.

PR-URL: #23300
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the no-wait-time branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants