-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update onboarding task #23300
Closed
Closed
doc: update onboarding task #23300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use fast-tracking on PRs where new Collaborators are adding themselves to the README.
vsemozhetbyt
approved these changes
Oct 6, 2018
refack
approved these changes
Oct 7, 2018
cjihrig
approved these changes
Oct 7, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 7, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves to the README. PR-URL: nodejs#23300 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in 061e098 |
targos
pushed a commit
that referenced
this pull request
Oct 7, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves to the README. PR-URL: #23300 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 7, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves to the README. PR-URL: #23300 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Oct 10, 2018
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Oct 12, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves to the README. PR-URL: nodejs#23300 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Use fast-tracking on PRs where new Collaborators are adding themselves to the README. PR-URL: #23300 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fast-tracking on PRs where new Collaborators are adding themselves
to the README.
👍 here to fast-track.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes