-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: refactor grow_async_ids_stack #23808
Conversation
src/aliased_buffer.h
Outdated
const v8::HandleScope handle_scope(isolate_); | ||
|
||
const size_t oldSizeInBytes = sizeof(NativeT) * count_; | ||
const size_t newSizeInBytes = sizeof(NativeT) * new_capacity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style nit: old_size_in_bytes
, new_size_in_bytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
Turned up the level of my IDE's inspection of these to "error".
src/aliased_buffer.h
Outdated
const size_t newSizeInBytes = sizeof(NativeT) * new_capacity; | ||
|
||
// allocate new native buffer | ||
auto new_buffer = Calloc<NativeT>(new_capacity); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style nit: NativeT* new_buffer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the style nits from @addaleax
888b26e
to
b845fd6
Compare
refactor grow_async_ids_stack PR-URL: nodejs#23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
PR-URL: nodejs#23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
b845fd6
to
586daae
Compare
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Marking dont-land-on-v11.x until nodejs/build#1542 is fixed |
@targos there are two more PR that will require GCC4.9 |
@targos the arm7 issue in ci-release was resolved - https://ci-release.nodejs.org/job/iojs+release/nodes=centos7-arm64-gcc6/3919/ |
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@refack thanks! I backported this (and others) to v11.x and confirmed: https://ci-release.nodejs.org/job/iojs+release/3934/nodes=centos7-arm64-gcc6/ |
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Added
AliasedBuffer::reserve()
CI: https://ci.nodejs.org/job/node-test-pull-request/18034/
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes