src: refactor grow_async_ids_stack #23808
Merged
+49
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
2 tasks
joyeecheung
reviewed
Oct 23, 2018
addaleax
reviewed
Oct 23, 2018
src/aliased_buffer.h
Outdated
| const v8::HandleScope handle_scope(isolate_); | ||
|
|
||
| const size_t oldSizeInBytes = sizeof(NativeT) * count_; | ||
| const size_t newSizeInBytes = sizeof(NativeT) * new_capacity; |
There was a problem hiding this comment.
style nit: old_size_in_bytes, new_size_in_bytes
There was a problem hiding this comment.
Ack.
Turned up the level of my IDE's inspection of these to "error".
src/aliased_buffer.h
Outdated
| const size_t newSizeInBytes = sizeof(NativeT) * new_capacity; | ||
|
|
||
| // allocate new native buffer | ||
| auto new_buffer = Calloc<NativeT>(new_capacity); |
There was a problem hiding this comment.
style nit: NativeT* new_buffer
joyeecheung
approved these changes
Oct 23, 2018
mmarchini
added
the
author ready
mmarchini
approved these changes
Oct 24, 2018
refack
force-pushed
the
grow_async_ids
branch
2 times, most recently
from
888b26e
to
b845fd6
Compare
refactor grow_async_ids_stack PR-URL: nodejs#23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
PR-URL: nodejs#23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
refack
force-pushed
the
grow_async_ids
branch
from
b845fd6
to
586daae
Compare
targos
pushed a commit
that referenced
this pull request
Oct 26, 2018
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos
pushed a commit
that referenced
this pull request
Oct 26, 2018
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Closed
|
Marking dont-land-on-v11.x until nodejs/build#1542 is fixed |
|
@targos there are two more PR that will require GCC4.9 |
|
@targos the arm7 issue in ci-release was resolved - https://ci-release.nodejs.org/job/iojs+release/nodes=centos7-arm64-gcc6/3919/ |
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos
pushed a commit
that referenced
this pull request
Nov 18, 2018
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
|
@refack thanks! I backported this (and others) to v11.x and confirmed: https://ci-release.nodejs.org/job/iojs+release/3934/nodes=centos7-arm64-gcc6/ |
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
refactor grow_async_ids_stack PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23808 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
This was referenced Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
AliasedBuffer::reserve()CI: https://ci.nodejs.org/job/node-test-pull-request/18034/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes