Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replaced anonymous fns with arrow syntax #24444

Closed
wants to merge 2 commits into from

Conversation

@pushkalb123
Copy link
Contributor

commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@targos
Copy link
Member

left a comment

Commit message should start with test: replace ...

test/parallel/test-stream-pipe-flow.js Outdated Show resolved Hide resolved
Update test/parallel/test-stream-pipe-flow.js
Co-Authored-By: pushkalb123 <pushkalb123@gmail.com>
@pushkalb123

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2018

@targos Accepted the changes. Please take a look at it.

@targos
targos approved these changes Nov 17, 2018
Copy link
Member

left a comment

Thank you

@targos

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track label Nov 17, 2018

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

Landed in b3b5fc7.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 18, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 18, 2018
test: use arrow functions for callbacks
PR-URL: nodejs#24444
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this pull request Nov 18, 2018
test: use arrow functions for callbacks
PR-URL: #24444
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: use arrow functions for callbacks
PR-URL: #24444
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
test: use arrow functions for callbacks
PR-URL: #24444
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: use arrow functions for callbacks
PR-URL: nodejs#24444
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
codebytere added a commit that referenced this pull request Jan 29, 2019
test: use arrow functions for callbacks
PR-URL: #24444
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.