Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] http2: fix sequence of error/close events #24789

Closed
wants to merge 1 commit into from
Closed

[v8.x] http2: fix sequence of error/close events #24789

wants to merge 1 commit into from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Dec 2, 2018

Correct sequence of emitting error and close events for a
Http2Stream.

Refs: #22850
Refs: #24685
Fixes: #24559

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Flarna
[v8.x] http2: fix sequence of error/close events
063abc4 
Correct sequence of emitting `error` and `close` events for a
`Http2Stream`.

Refs: #22850
Refs: #24685
Fixes: #24559
@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Dec 2, 2018
This was referenced Dec 2, 2018
Closed
Closed
@lpinca
Copy link
Member

lpinca commented Dec 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19143/

@BethGriggs
Copy link
Member

Could we get a review from @nodejs/http2?

@mcollina
Copy link
Member

mcollina commented Dec 4, 2018

I think the original commit should be cherry-picked: e03bcb1.

mcollina
mcollina approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the code change

@Flarna
Copy link
Member Author

Flarna commented Dec 5, 2018

is cherry-picking something I should do in this PR or is this done during integration on v8.x branch?
I'm also not sure about the commit line as it seems [v8.x] http2 is not correct. What is the correct prefix for a fix on v8.x http2?

BethGriggs pushed a commit that referenced this pull request Dec 11, 2018
@Flarna @BethGriggs
http2: fix sequence of error/close events
4c24a82 
Correct sequence of emitting `error` and `close` events for a
`Http2Stream`.

PR-URL: #24789
Refs: #22850
Refs: #24685
Fixes: #24559
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs
Copy link
Member

@Flarna, I cherry-picked e03bcb1 and then landed your changes on top.

Landed in 4c24a82

@BethGriggs BethGriggs closed this Dec 11, 2018
BethGriggs added a commit that referenced this pull request Dec 11, 2018
@BethGriggs
2018-12-18, Version 8.14.1 'Carbon' (LTS)
9fc8d9a 
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832
@BethGriggs BethGriggs mentioned this pull request Dec 11, 2018
Merged
@Flarna Flarna deleted the http2_event_sequence branch December 11, 2018 18:28
MylesBorins pushed a commit that referenced this pull request Dec 18, 2018
@BethGriggs @MylesBorins
2018-12-18, Version 8.14.1 'Carbon' (LTS)
187694e 
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832
MylesBorins pushed a commit that referenced this pull request Dec 18, 2018
@BethGriggs @MylesBorins
2018-12-18, Version 8.14.1 'Carbon' (LTS)
1cbd377 
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BethGriggs @refack
2018-12-18, Version 8.14.1 'Carbon' (LTS)
d28c3af 
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [nodejs#24786](nodejs#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [nodejs#24789](nodejs#24789)

PR-URL: nodejs#24832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Flarna @lpinca @BethGriggs @mcollina @trivikr @nodejs-github-bot