New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] http2: fix sequence of error/close events #24789

Closed
wants to merge 1 commit into
base: v8.x-staging
from

Conversation

Projects
None yet
6 participants
@Flarna
Copy link
Member

Flarna commented Dec 2, 2018

Correct sequence of emitting error and close events for a
Http2Stream.

Refs: #22850
Refs: #24685
Fixes: #24559

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
[v8.x] http2: fix sequence of error/close events
Correct sequence of emitting `error` and `close` events for a
`Http2Stream`.

Refs: #22850
Refs: #24685
Fixes: #24559
@lpinca

lpinca approved these changes Dec 3, 2018

@lpinca

This comment has been minimized.

@BethGriggs

This comment has been minimized.

Copy link
Member

BethGriggs commented Dec 4, 2018

Could we get a review from @nodejs/http2?

@mcollina

This comment has been minimized.

Copy link
Member

mcollina commented Dec 4, 2018

I think the original commit should be cherry-picked: e03bcb1.

@mcollina
Copy link
Member

mcollina left a comment

LGTM on the code change

@Flarna

This comment has been minimized.

Copy link
Member

Flarna commented Dec 5, 2018

is cherry-picking something I should do in this PR or is this done during integration on v8.x branch?
I'm also not sure about the commit line as it seems [v8.x] http2 is not correct. What is the correct prefix for a fix on v8.x http2?

@trivikr

trivikr approved these changes Dec 8, 2018

BethGriggs added a commit that referenced this pull request Dec 11, 2018

http2: fix sequence of error/close events
Correct sequence of emitting `error` and `close` events for a
`Http2Stream`.

PR-URL: #24789
Refs: #22850
Refs: #24685
Fixes: #24559
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs

This comment has been minimized.

Copy link
Member

BethGriggs commented Dec 11, 2018

@Flarna, I cherry-picked e03bcb1 and then landed your changes on top.

Landed in 4c24a82

@BethGriggs BethGriggs closed this Dec 11, 2018

BethGriggs added a commit that referenced this pull request Dec 11, 2018

2018-12-18, Version 8.14.1 'Carbon' (LTS)
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832

@BethGriggs BethGriggs referenced this pull request Dec 11, 2018

Merged

v8.14.1 proposal #24832

@Flarna Flarna deleted the Flarna:http2_event_sequence branch Dec 11, 2018

MylesBorins added a commit that referenced this pull request Dec 18, 2018

2018-12-18, Version 8.14.1 'Carbon' (LTS)
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832

MylesBorins added a commit that referenced this pull request Dec 18, 2018

2018-12-18, Version 8.14.1 'Carbon' (LTS)
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832

MylesBorins added a commit that referenced this pull request Dec 18, 2018

2018-12-18, Version 8.14.1 'Carbon' (LTS)
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [#24786](#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [#24789](#24789)

PR-URL: #24832

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

2018-12-18, Version 8.14.1 'Carbon' (LTS)
Notable changes:

* **assert**:
  - revert breaking change (Ruben Bridgewater)
    [nodejs#24786](nodejs#24786)
* **http2**:
  - fix sequence of error/close events (Gerhard Stoebich)
    [nodejs#24789](nodejs#24789)

PR-URL: nodejs#24832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment