Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace callback with arrows #24866

Closed
wants to merge 1 commit into from

Conversation

@Shubhamurkade
Copy link
Contributor

commented Dec 6, 2018

Replaced a callback function with arrow function in test-process-config.js

@danbev
danbev approved these changes Dec 10, 2018
@danbev

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@Trott Trott added the author ready label Dec 10, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

@danbev

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Re-run of failing node-test-commit-linux

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Landed in 91c0a37

@Trott Trott closed this Dec 11, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 11, 2018
test: replace callback with arrows
PR-URL: nodejs#24866
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit that referenced this pull request Dec 17, 2018
test: replace callback with arrows
PR-URL: #24866
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: replace callback with arrows
PR-URL: nodejs#24866
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: replace callback with arrows
PR-URL: #24866
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
test: replace callback with arrows
PR-URL: #24866
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: replace callback with arrows
PR-URL: #24866
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.