Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fulfill Maybe contract in InlineDecoder #25140

Closed
wants to merge 1 commit into from
Closed

src: fulfill Maybe contract in InlineDecoder #25140

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Use an empty/nothing Maybe<> to indicate a pending exception.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: fulfill Maybe contract in InlineDecoder
5108708 
Use an empty/nothing `Maybe<>` to indicate a pending exception.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2008/pipeline

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Dec 19, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19833/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 27, 2018
@addaleax
Copy link
Member Author

Landed in b4b9e0e

@addaleax addaleax closed this Dec 30, 2018
@addaleax addaleax deleted the inline-decoder-maybe branch December 30, 2018 19:16
addaleax added a commit that referenced this pull request Dec 30, 2018
@addaleax
src: fulfill Maybe contract in InlineDecoder
b4b9e0e 
Use an empty/nothing `Maybe<>` to indicate a pending exception.

PR-URL: #25140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2019
@addaleax @targos
src: fulfill Maybe contract in InlineDecoder
c9d49d6 
Use an empty/nothing `Maybe<>` to indicate a pending exception.

PR-URL: #25140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
src: fulfill Maybe contract in InlineDecoder
172f11f 
Use an empty/nothing `Maybe<>` to indicate a pending exception.

PR-URL: nodejs#25140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Jul 2, 2019
@addaleax @BethGriggs
src: fulfill Maybe contract in InlineDecoder
471701b 
Use an empty/nothing `Maybe<>` to indicate a pending exception.

PR-URL: #25140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Jul 17, 2019
@addaleax @BethGriggs
src: fulfill Maybe contract in InlineDecoder
a8f78f0 
Use an empty/nothing `Maybe<>` to indicate a pending exception.

PR-URL: #25140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@codebytere codebytere codebytere approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@addaleax @nodejs-github-bot @jasnell @codebytere @cjihrig @joyeecheung