Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: restrict unloading addons to Worker threads #25577

Closed
wants to merge 2 commits into from
Closed

src: restrict unloading addons to Worker threads #25577

wants to merge 2 commits into from

Commits on Jan 22, 2019

  1. src: restrict unloading addons to Worker threads 

    Unloading native addons from the main thread was an (presumably
unintended) significant breaking change, because addons may
rely on their memory being available after an `Environment` exits.

This patch only restricts this to Worker threads, at least for the
time being, and thus matches the behaviour from
nodejs#23319.

Refs: nodejs#24861
Refs: nodejs#23319
    @addaleax
    addaleax committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    0934abd View commit details
    Browse the repository at this point in the history

  2. fixup! src: restrict unloading addons to Worker threads

    @addaleax
    addaleax committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    d7d409a View commit details
    Browse the repository at this point in the history