/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move client renegotiation tests to parallel #25757

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@sam-github sam-github

@jasnell jasnell

@lpinca lpinca

@BethGriggs BethGriggs

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
6 participants
@Trott @nodejs-github-bot @sam-github @jasnell @lpinca @BethGriggs
@Trott
Copy link
Member

Trott commented Jan 28, 2019

  • Move client renegotiation limit tests from pummel to parallel.
  • Rename tests to more accurately reflect what they do.
  • Refactor to use arrow functions for anonymouse callbacks and to be
    consistent about trailing commas.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
test: move client renegotiation tests to parallel 
* Move client renegotiation limit tests from pummel to parallel.
* Rename tests to more accurately reflect what they do.
* Refactor to use  arrow functions for anonymouse callbacks and to be
  consistent about trailing commas.
Loading status checks…
347a67e
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Jan 28, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Jan 28, 2019 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/20371/ ✅
@BethGriggs

BethGriggs approved these changes Jan 28, 2019
View changes

@Trott Trott added the author ready label Jan 28, 2019

@sam-github

sam-github approved these changes Jan 28, 2019
View changes

@lpinca

lpinca approved these changes Jan 29, 2019
View changes

@jasnell

jasnell approved these changes Jan 29, 2019
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Jan 30, 2019

Landed in 86a49ce

@Trott Trott closed this Jan 30, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 30, 2019

@Trott
test: move client renegotiation tests to parallel 
* Move client renegotiation limit tests from pummel to parallel.
* Rename tests to more accurately reflect what they do.
* Refactor to use  arrow functions for anonymouse callbacks and to be
  consistent about trailing commas.

PR-URL: nodejs#25757
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
86a49ce

targos added a commit that referenced this pull request Jan 30, 2019

@Trott @targos
test: move client renegotiation tests to parallel 
* Move client renegotiation limit tests from pummel to parallel.
* Rename tests to more accurately reflect what they do.
* Refactor to use  arrow functions for anonymouse callbacks and to be
  consistent about trailing commas.

PR-URL: #25757
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
d04c0bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment