Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix bad cherry-pick for vcbuild.bat build-release #2625

Closed
wants to merge 1 commit into from
Closed

build: fix bad cherry-pick for vcbuild.bat build-release #2625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ set noperfctr_msi_arg=
set i18n_arg=
set download_arg=
set release_urls_arg=
set build_release=

:next-arg
set build_release=
if "%1"=="" goto args-done
if /i "%1"=="debug" set config=Debug&goto arg-ok
if /i "%1"=="release" set config=Release&goto arg-ok
Expand Down Expand Up @@ -78,17 +78,17 @@ echo Warning: ignoring invalid command line option `%1`.
:arg-ok
shift
goto next-arg

:args-done

if defined build_release (
set nosnapshot=1
set config=Release
set msi=1
set licensertf=1
set download_arg="--download=all"
set i18n_arg=small-icu
)


:args-done
if "%config%"=="Debug" set debug_arg=--debug
if defined nosnapshot set snapshot_arg=--without-snapshot
if defined noetw set noetw_arg=--without-etw& set noetw_msi_arg=/p:NoETW=1
Expand Down Expand Up @@ -260,10 +260,10 @@ echo vcbuild.bat : builds release build
echo vcbuild.bat debug : builds debug build
echo vcbuild.bat release msi : builds release build and MSI installer package
echo vcbuild.bat test : builds debug build and runs tests
echo vcbuild.bat build-release : builds the release distribution as used by nodejs.org
goto exit

:exit
echo vcbuild.bat build-release : builds the release distribution as used by nodejs.org
goto :EOF

rem ***************
Expand Down