Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit "Involving the TSC" #26481

Closed
wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

commented Mar 6, 2019

Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

One thing I didn't do here but that I would definitely do if there is consensus: Remove mention of the tsc-review label and just tell people to @-mention the TSC. Sure, notification overload is a problem, but the tsc-review label always gets ignored. It's not even a placebo.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: edit "Involving the TSC"
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Update COLLABORATOR_GUIDE.md
Co-Authored-By: Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

@Trott Trott added the author ready label Mar 6, 2019

@hiroppy
hiroppy approved these changes Mar 7, 2019
@targos

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Remove mention of the tsc-review label and just tell people to @-mention the TSC.

Yes, please!

@targos
targos approved these changes Mar 7, 2019
@jasnell
jasnell approved these changes Mar 7, 2019
@cjihrig
cjihrig approved these changes Mar 7, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

Landed in ed465eb

@Trott Trott closed this Mar 8, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 8, 2019
doc: edit "Involving the TSC"
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: nodejs#26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
doc: edit "Involving the TSC"
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: nodejs#26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
doc: edit "Involving the TSC"
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: nodejs#26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
doc: edit "Involving the TSC"
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: #26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
doc: edit "Involving the TSC"
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: #26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.