tools: update paths in v8_external_snapshot.gypi #29363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the paths to source files in v8_external_snapshot.gypi this was broken and went unnoticed since this target is never really built by default. Fixes: nodejs#28964
gengjiawen
approved these changes
Aug 29, 2019
Me too. Why the CI doesn't fail. Is it we need to enhance in CI or remove the target. |
gengjiawen
added
gyp
|
We never set |
|
@bnoordhuis perfect! I'll remove the target in that case and update the PR appropriately. |
|
Closing this in favor of a new PR since that'll be less confusing. |
ryzokuken
added a commit
to ryzokuken/node
that referenced
this pull request
Aug 29, 2019
Delete the v8_external_snapshot target from gyp and disable the v8_use_external_startup_data option since it is never used anyway. Refs: nodejs#29363 (comment) Fixes: nodejs#28964
4 tasks
ryzokuken
added a commit
that referenced
this pull request
Sep 5, 2019
Delete the v8_external_snapshot target from gyp and disable the v8_use_external_startup_data option since it is never used anyway. Refs: #29363 (comment) Fixes: #28964 PR-URL: #29369 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Delete the v8_external_snapshot target from gyp and disable the v8_use_external_startup_data option since it is never used anyway. Refs: #29363 (comment) Fixes: #28964 PR-URL: #29369 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the paths to source files in v8_external_snapshot.gypi this was
broken and went unnoticed since this target is never really built by
default.
Fixes: #28964
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @refack @gengjiawen
I'm not sure how relevant this is and if CI can even check for this. Maybe we should consider just removing this target at some point?