Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix broken pipeline error propagation #31835

Closed
wants to merge 4 commits into from
Closed

stream: fix broken pipeline error propagation #31835

wants to merge 4 commits into from

Commits on Feb 21, 2020

  1. stream: fix broken pipeline error propagation 

    If the destination was an async function any
error thrown from that function would be swallowed.
    @ronag
    ronag committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    f07a2d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2020

  1. fixup: don't call end if destroyed

    @ronag
    ronag committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    86f40d3 View commit details
    Browse the repository at this point in the history

  2. Update test/parallel/test-stream-pipeline-uncaught.js 

    Co-Authored-By: Denys Otrishko <shishugi@gmail.com>
    @ronag @lundibundi
    ronag and lundibundi committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    f4a1245 View commit details
    Browse the repository at this point in the history

  3. fixup: nits

    @ronag
    ronag committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    40c0b13 View commit details
    Browse the repository at this point in the history