Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: typo Experimenetal to Experimental #3260

Closed
wants to merge 1 commit into from
Closed

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Oct 8, 2015

No description provided.

@@ -4,7 +4,7 @@
## 2015-10-05, Version 4.1.2 (Stable), @rvagg

### Notable changes

Experimenetal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's unintended?

@reggi
Copy link
Contributor Author

reggi commented Oct 8, 2015

@targos Sorry about that, thanks for the catch!

@reggi
Copy link
Contributor Author

reggi commented Oct 8, 2015

Ugh Atom removed a trailing space too.

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Oct 8, 2015
@ChALkeR
Copy link
Member

ChALkeR commented Oct 8, 2015

I see a lot of commits here: https://github.com/nodejs/node/pulls?q=is%3Aopen+is%3Apr+author%3Areggi+label%3Adoc+typo (namely 11).
Those would create a lot of commit noise. Why not unify them under one pull request and then squash to a single commit?
/cc @Fishrock123

@silverwind
Copy link
Contributor

Yes, merge them into one pull request please. Commiters can squash on merge, so it's not of concern if you have multiple commits in a single PR. I think we should add to CONTRIBUTING.md that we prefer single PRs for related changes.

@ChALkeR
Copy link
Member

ChALkeR commented Oct 9, 2015

Replaced by #3291.

@ChALkeR ChALkeR closed this Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants